Background monitor #198
Merged
Background monitor #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the fdo support code behind an api. This is in preparation for using it from the background portal backend.
This was referenced May 13, 2019
|
One issue with this: we are currently getting the wrong information from gnome-shell. It puts desktop filenames into the windows list, which we misinterpret as app ids. |
Add a portal backend for getting the list of active applications, and for showing a notification about apps that are running in the background.
matthiasclasen
force-pushed
the
background-monitor
branch
from
d3f0171 to
8b306a7
Compare
|
gnome-shell issue: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1289 |
hadess
reviewed
May 14, 2019
alexlarsson
reviewed
May 14, 2019
matthiasclasen
force-pushed
the
background-monitor
branch
from
324d4c7 to
de56b42
Compare
alexlarsson
reviewed
May 14, 2019
alexlarsson
reviewed
May 14, 2019
alexlarsson
reviewed
May 14, 2019
Implement the EnableAutostart method by generating an autostart file for the application in XDG_CONFIG_HOME/autostart.
matthiasclasen
force-pushed
the
background-monitor
branch
from
de56b42 to
e50ce25
Compare
The gnome-shell introspection api returns us desktop file names instead of proper app ids. Work around this by looking for X-Flatpak.
alexlarsson
reviewed
May 15, 2019
src/background.c
Outdated
| goto out; | ||
| } | ||
|
|
||
| commandline = g_strjoinv (" ", (char **)arg_commandline); |
There was a problem hiding this comment.
I think this is where we should do any required escaping, rather than in the portal.
added 3 commits
May 15, 2019 11:32
Use flags for autostart
More flexible NotifyBackground api
Add an allow-once option
alexlarsson
reviewed
May 16, 2019
src/background.c
Outdated
| goto out; | ||
| } | ||
|
|
||
| commandline = g_strjoinv (" ", (char **)arg_commandline); |
There was a problem hiding this comment.
You still need to escape here
quote commandline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the platform-dependent parts of flatpak/xdg-desktop-portal#319